summaryrefslogtreecommitdiffstats
path: root/drivers/net/bnx2x_main.c
diff options
context:
space:
mode:
authorStanislaw Gruszka <sgruszka@redhat.com>2010-03-09 06:55:00 +0000
committerDavid S. Miller <davem@davemloft.net>2010-03-15 15:47:00 -0700
commit2d99cf16f42b1979a2c498bb6d09498dbd689978 (patch)
treea67758700d34a0559f69783a54041a4e94405f03 /drivers/net/bnx2x_main.c
parentd4a2ac3e802d9f598453a7854d0fdf67371ac2dd (diff)
downloadop-kernel-dev-2d99cf16f42b1979a2c498bb6d09498dbd689978.zip
op-kernel-dev-2d99cf16f42b1979a2c498bb6d09498dbd689978.tar.gz
bnx2x: use smp_mb() to keep ordering of read write operations
Since we want to keep ordering of write to fp->bd_tx_cons and netif_tx_queue_stopped(txq), what is read of txq->state, we have to use general memory barrier. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bnx2x_main.c')
-rw-r--r--drivers/net/bnx2x_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index ed785a3..9fc0f6a 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -963,7 +963,7 @@ static int bnx2x_tx_int(struct bnx2x_fastpath *fp)
* start_xmit() will miss it and cause the queue to be stopped
* forever.
*/
- smp_wmb();
+ smp_mb();
/* TBD need a thresh? */
if (unlikely(netif_tx_queue_stopped(txq))) {
OpenPOWER on IntegriCloud