diff options
| author | Julia Lawall <julia@diku.dk> | 2007-12-10 17:17:37 -0800 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2007-12-11 02:45:29 -0800 |
| commit | 9b3efc0133a807070dbd21254102995b65969965 (patch) | |
| tree | 86f609aef9c7e2534ccf7f1a1b06d8e29c2ba676 /drivers/net/bnx2.c | |
| parent | 299f590f26da9764f20e905879f0090552ff2e86 (diff) | |
| download | op-kernel-dev-9b3efc0133a807070dbd21254102995b65969965.zip op-kernel-dev-9b3efc0133a807070dbd21254102995b65969965.tar.gz | |
[S390]: Fix use of skb after netif_rx
Recently, Wang Chen submitted a patch
(d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may call kfree_skb on
its argument. netif_rx_ni calls netif_rx, so the same problem occurs in
the files below.
I have left the updating of dev->last_rx after the calls to netif_rx_ni
because it seems time dependent, but moved the other field updates before.
This was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression skb, e,e1;
@@
(
netif_rx(skb);
|
netif_rx_ni(skb);
)
... when != skb = e
(
skb = e1
|
* skb
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bnx2.c')
0 files changed, 0 insertions, 0 deletions
