diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2008-05-23 02:00:25 +0400 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2008-05-30 22:07:25 -0400 |
| commit | aefdbf1a3b832a580a50cf3d1dcbb717be7cbdbe (patch) | |
| tree | 8424a76c31a2d03204f58e2b155564ff8fbee953 /drivers/net/atlx | |
| parent | 08722bc4a066705e3f5fb4a5a87ce717fe9f896e (diff) | |
| download | op-kernel-dev-aefdbf1a3b832a580a50cf3d1dcbb717be7cbdbe.zip op-kernel-dev-aefdbf1a3b832a580a50cf3d1dcbb717be7cbdbe.tar.gz | |
atl1: fix 4G memory corruption bug
When using 4+ GB RAM and SWIOTLB is active, the driver corrupts
memory by writing an skb after the relevant DMA page has been
unmapped. Although this doesn't happen when *not* using bounce
buffers, clearing the pointer to the DMA page after unmapping
it fixes the problem.
http://marc.info/?t=120861317000005&r=2&w=2
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net/atlx')
| -rw-r--r-- | drivers/net/atlx/atl1.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c index 9c2394d..79325c4 100644 --- a/drivers/net/atlx/atl1.c +++ b/drivers/net/atlx/atl1.c @@ -2023,6 +2023,7 @@ rrd_ok: /* Good Receive */ pci_unmap_page(adapter->pdev, buffer_info->dma, buffer_info->length, PCI_DMA_FROMDEVICE); + buffer_info->dma = 0; skb = buffer_info->skb; length = le16_to_cpu(rrd->xsz.xsum_sz.pkt_size); |
