diff options
| author | Nicolas Kaiser <nikai@nikai.net> | 2010-10-22 12:47:24 +0200 |
|---|---|---|
| committer | David Woodhouse <David.Woodhouse@intel.com> | 2010-10-26 10:58:00 +0100 |
| commit | 89a82280a8e632b7a5b0ce70dd5bccfa2d3bc2c5 (patch) | |
| tree | edf833a4eca968961cca4d3612e6b405b9bcf73f /drivers/mtd | |
| parent | 0b824d2b10eacd496c608a7c41a046862d48563b (diff) | |
| download | op-kernel-dev-89a82280a8e632b7a5b0ce70dd5bccfa2d3bc2c5.zip op-kernel-dev-89a82280a8e632b7a5b0ce70dd5bccfa2d3bc2c5.tar.gz | |
block2mtd: dubious assignment
When block2mtd_erase fails, a duplicated assignment instantly
changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.
It looks to me like this might not be intended, or is it?
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-By: Joern Engel <joern@logfs.org>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/devices/block2mtd.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c index 9365186..2cf0cc6 100644 --- a/drivers/mtd/devices/block2mtd.c +++ b/drivers/mtd/devices/block2mtd.c @@ -91,7 +91,6 @@ static int block2mtd_erase(struct mtd_info *mtd, struct erase_info *instr) } else instr->state = MTD_ERASE_DONE; - instr->state = MTD_ERASE_DONE; mtd_erase_callback(instr); return err; } |
