diff options
| author | Brian Norris <computersforpeace@gmail.com> | 2015-05-21 10:44:32 -0700 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2015-05-21 10:44:32 -0700 |
| commit | c4a3f13c2ab997617eaf7020af33b057a68285fd (patch) | |
| tree | 4dfd5c65ea9dfa43ba0e02a6ac524df0c8355df4 /drivers/mtd | |
| parent | 01d0afddf37cbb4da8581d6dc9bfa5b63bae3390 (diff) | |
| download | op-kernel-dev-c4a3f13c2ab997617eaf7020af33b057a68285fd.zip op-kernel-dev-c4a3f13c2ab997617eaf7020af33b057a68285fd.tar.gz | |
mtd: blktrans: use better error code for unimplemented ioctl()
In commit 50183936254b ("mtd: blktrans: change blktrans_getgeo return
value") we fixed the problem that ioctl(HDIO_GETGEO) might return 0
(success) for mtdblock devices which did not implement the feature and
would leave a blank (zero) result.
But now, let's get the error code right. Other code paths on this ioctl
tend to use -ENOTTY to notify the user that the ioctl() is not supported
for the device, so let's use that instead of -EOPNOTSUPP.
Suggested-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/mtd_blkdevs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index c545c93..41acc50 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -278,7 +278,7 @@ static int blktrans_getgeo(struct block_device *bdev, struct hd_geometry *geo) if (!dev->mtd) goto unlock; - ret = dev->tr->getgeo ? dev->tr->getgeo(dev, geo) : -EOPNOTSUPP; + ret = dev->tr->getgeo ? dev->tr->getgeo(dev, geo) : -ENOTTY; unlock: mutex_unlock(&dev->lock); blktrans_dev_put(dev); |
