diff options
| author | Sachin Kamat <sachin.kamat@linaro.org> | 2012-09-25 15:27:13 +0530 |
|---|---|---|
| committer | David Woodhouse <David.Woodhouse@intel.com> | 2012-10-10 09:12:39 +0100 |
| commit | 5a6ea4af0907f995dc06df21a9c9ef764c7cd3bc (patch) | |
| tree | d1304c5c2f798c9ddf69c18ecb1f40969e5e8b62 /drivers/mtd | |
| parent | bc86cf7af2ebda88056538e8edff852ee627f76a (diff) | |
| download | op-kernel-dev-5a6ea4af0907f995dc06df21a9c9ef764c7cd3bc.zip op-kernel-dev-5a6ea4af0907f995dc06df21a9c9ef764c7cd3bc.tar.gz | |
mtd: ofpart: Fix incorrect NULL check in parse_ofoldpart_partitions()
The pointer returned by kzalloc should be tested for NULL
to avoid potential NULL pointer dereference later. Incorrect
pointer was being tested for NULL. Bug introduced by commit fbcf62a3
(mtd: physmap_of: move parse_obsolete_partitions to become separate
parser).
This patch fixes this bug.
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
Cc: stable@kernel.org
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/ofpart.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c index 64be8f08..d9127e2 100644 --- a/drivers/mtd/ofpart.c +++ b/drivers/mtd/ofpart.c @@ -121,7 +121,7 @@ static int parse_ofoldpart_partitions(struct mtd_info *master, nr_parts = plen / sizeof(part[0]); *pparts = kzalloc(nr_parts * sizeof(*(*pparts)), GFP_KERNEL); - if (!pparts) + if (!*pparts) return -ENOMEM; names = of_get_property(dp, "partition-names", &plen); |
