summaryrefslogtreecommitdiffstats
path: root/drivers/mtd
diff options
context:
space:
mode:
authorAtsushi Nemoto <anemo@mba.ocn.ne.jp>2008-07-19 01:01:22 +0900
committerDavid Woodhouse <David.Woodhouse@intel.com>2008-07-25 10:00:11 -0400
commitf636ffb420f0f9059c1d0b841afd691657246ad6 (patch)
treef1aaf8fedaf98f6143ea1a560c24430a14ac8def /drivers/mtd
parent6910c1368104d50e6b6afc6c8b7e9d1670a374e7 (diff)
downloadop-kernel-dev-f636ffb420f0f9059c1d0b841afd691657246ad6.zip
op-kernel-dev-f636ffb420f0f9059c1d0b841afd691657246ad6.tar.gz
[MTD][MTDPART] Fix a division by zero bug
When detecting a partition beyond the end of the device, skip most of the initialisation, in particular those bits causing a division by zero. Signed-off-by: Jörn Engel <joern@logfs.org> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd')
-rw-r--r--drivers/mtd/mtdpart.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 5aac59c..edb90b5 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -411,11 +411,12 @@ static struct mtd_part *add_one_partition(struct mtd_info *master,
/* let's do some sanity checks */
if (slave->offset >= master->size) {
- /* let's register it anyway to preserve ordering */
+ /* let's register it anyway to preserve ordering */
slave->offset = 0;
slave->mtd.size = 0;
printk(KERN_ERR"mtd: partition \"%s\" is out of reach -- disabled\n",
part->name);
+ goto out_register;
}
if (slave->offset + slave->mtd.size > master->size) {
slave->mtd.size = master->size - slave->offset;
@@ -475,6 +476,7 @@ static struct mtd_part *add_one_partition(struct mtd_info *master,
}
}
+out_register:
if (part->mtdp) {
/* store the object pointer (caller may or may not register it*/
*part->mtdp = &slave->mtd;
OpenPOWER on IntegriCloud