summaryrefslogtreecommitdiffstats
path: root/drivers/mtd
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2018-01-16 08:43:40 +0100
committerBoris Brezillon <boris.brezillon@free-electrons.com>2018-01-16 09:25:12 +0100
commit82cea533aed44c1b8553fe782e1bc5e1262bd71a (patch)
treef06eaff35ae2462856b111561d280bcaae0e8419 /drivers/mtd
parent6837befde3a6b42a36c894a4f86bafdc6db82534 (diff)
downloadop-kernel-dev-82cea533aed44c1b8553fe782e1bc5e1262bd71a.zip
op-kernel-dev-82cea533aed44c1b8553fe782e1bc5e1262bd71a.tar.gz
mtd: onenand: omap2: print resource using %pR format string
The omap2 onenand driver is now available for compile-testing, which uncovers a warning in configurations that have a 64-bit resource_size_t: drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_probe': drivers/mtd/onenand/omap2.c:536:54: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=] dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n", drivers/mtd/onenand/omap2.c:536:66: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=] Changing the format string to the special %pR simplifies the code and lets it do the right thing in that configuration, while avoiding the warning. Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Diffstat (limited to 'drivers/mtd')
-rw-r--r--drivers/mtd/onenand/omap2.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index 2ce73fb..a4a2159 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -533,8 +533,7 @@ static int omap2_onenand_probe(struct platform_device *pdev)
c->onenand.base = devm_ioremap_resource(dev, res);
if (IS_ERR(c->onenand.base)) {
- dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",
- res->start, resource_size(res));
+ dev_err(dev, "Cannot reserve memory region %pR\n", res);
return PTR_ERR(c->onenand.base);
}
OpenPOWER on IntegriCloud