summaryrefslogtreecommitdiffstats
path: root/drivers/mtd/tests
diff options
context:
space:
mode:
authorDavid Lambert <dave@lambsys.com>2011-03-07 12:00:46 +0200
committerDavid Woodhouse <David.Woodhouse@intel.com>2011-03-11 14:22:49 +0000
commite70727e442eb61581f836a9a0ca0c3b70d8a3ff2 (patch)
tree52691fbc86e772642978cc09a32eaaf807ef1016 /drivers/mtd/tests
parent5d9d9936209e589569a97985285b3282310cf2db (diff)
downloadop-kernel-dev-e70727e442eb61581f836a9a0ca0c3b70d8a3ff2.zip
op-kernel-dev-e70727e442eb61581f836a9a0ca0c3b70d8a3ff2.tar.gz
mtd: speedtest: fix integer overflow
32-bit integers used in 'calc_speed()' may overflow and lead to incorrect results. Use 64-bit integers instead. Signed-off-by: David Lambert <dave@lambsys.com> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd/tests')
-rw-r--r--drivers/mtd/tests/mtd_speedtest.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/mtd/tests/mtd_speedtest.c b/drivers/mtd/tests/mtd_speedtest.c
index 3ce6fce..627d4e2 100644
--- a/drivers/mtd/tests/mtd_speedtest.c
+++ b/drivers/mtd/tests/mtd_speedtest.c
@@ -314,16 +314,16 @@ static inline void stop_timing(void)
static long calc_speed(void)
{
- long ms, k, speed;
+ uint64_t k;
+ long ms;
ms = (finish.tv_sec - start.tv_sec) * 1000 +
(finish.tv_usec - start.tv_usec) / 1000;
- k = goodebcnt * mtd->erasesize / 1024;
- if (ms)
- speed = (k * 1000) / ms;
- else
- speed = 0;
- return speed;
+ if (ms == 0)
+ return 0;
+ k = goodebcnt * (mtd->erasesize / 1024) * 1000;
+ do_div(k, ms);
+ return k;
}
static int scan_for_bad_eraseblocks(void)
OpenPOWER on IntegriCloud