diff options
| author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2017-06-13 22:45:35 +0900 |
|---|---|---|
| committer | Boris Brezillon <boris.brezillon@free-electrons.com> | 2017-06-20 09:14:21 +0200 |
| commit | b21ff825d6b7fa7122f9c4455f9a0f157b9fb225 (patch) | |
| tree | 42936b77a5a73af3fb9a8cbceb2937a7bcaabcdd /drivers/mtd/nand/denali.h | |
| parent | d690694be93332cf7a91a6024b0598601f5f993a (diff) | |
| download | op-kernel-dev-b21ff825d6b7fa7122f9c4455f9a0f157b9fb225.zip op-kernel-dev-b21ff825d6b7fa7122f9c4455f9a0f157b9fb225.tar.gz | |
mtd: nand: denali: set NAND_ECC_CUSTOM_PAGE_ACCESS
The denali_cmdfunc() actually does nothing valuable for
NAND_CMD_{PAGEPROG,READ0,SEQIN}.
For NAND_CMD_{READ0,SEQIN}, it copies "page" to "denali->page", then
denali_read_page(_raw) compares them just for the sanity check.
(Inconsistently, this check is missing from denali_write_page(_raw).)
The Denali controller is equipped with high level read/write interface,
so let's skip unneeded call of cmdfunc().
If NAND_ECC_CUSTOM_PAGE_ACCESS is set, nand_write_page() will not
call ->waitfunc hook. So, ->write_page(_raw) hooks should directly
return -EIO on failure. The error handling of page writes will be
much simpler.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Diffstat (limited to 'drivers/mtd/nand/denali.h')
| -rw-r--r-- | drivers/mtd/nand/denali.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h index a06ed74..352d832 100644 --- a/drivers/mtd/nand/denali.h +++ b/drivers/mtd/nand/denali.h @@ -323,7 +323,6 @@ struct nand_buf { struct denali_nand_info { struct nand_chip nand; int flash_bank; /* currently selected chip */ - int status; int platform; struct nand_buf buf; struct device *dev; |
