diff options
| author | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2012-02-06 13:27:43 +0200 |
|---|---|---|
| committer | David Woodhouse <David.Woodhouse@intel.com> | 2012-03-27 00:32:19 +0100 |
| commit | bcb1d238716d138c9e16347fc32b3c1ae006339e (patch) | |
| tree | ccb7a9aea7b77481fa3474124218521e0c32de82 /drivers/mtd/maps | |
| parent | 0dd5235f51fb0eb0b8cef3fed35be39b8a06d7bd (diff) | |
| download | op-kernel-dev-bcb1d238716d138c9e16347fc32b3c1ae006339e.zip op-kernel-dev-bcb1d238716d138c9e16347fc32b3c1ae006339e.tar.gz | |
mtd: move zero length verification to MTD API functions
In many places in drivers we verify for the zero length, but this is very
inconsistent across drivers. This is obviously the right thing to do, though.
This patch moves the check to the MTD API functions instead and removes a lot
of duplication.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd/maps')
| -rw-r--r-- | drivers/mtd/maps/vmu-flash.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/mtd/maps/vmu-flash.c b/drivers/mtd/maps/vmu-flash.c index 48a803e..2e2b094 100644 --- a/drivers/mtd/maps/vmu-flash.c +++ b/drivers/mtd/maps/vmu-flash.c @@ -360,9 +360,6 @@ static int vmu_flash_read(struct mtd_info *mtd, loff_t from, size_t len, int index = 0, retval, partition, leftover, numblocks; unsigned char cx; - if (len < 1) - return -EIO; - mpart = mtd->priv; mdev = mpart->mdev; partition = mpart->partition; @@ -434,11 +431,6 @@ static int vmu_flash_write(struct mtd_info *mtd, loff_t to, size_t len, partition = mpart->partition; card = maple_get_drvdata(mdev); - /* simple sanity checks */ - if (len < 1) { - error = -EIO; - goto failed; - } numblocks = card->parts[partition].numblocks; if (to + len > numblocks * card->blocklen) len = numblocks * card->blocklen - to; |
