diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2009-09-18 12:51:49 -0700 |
|---|---|---|
| committer | David Woodhouse <David.Woodhouse@intel.com> | 2009-09-19 11:18:15 -0700 |
| commit | 4c1e6b2ce13b154a4a69cee220c98976f4b784df (patch) | |
| tree | 02109e88a695ab4dde00418a143cd7379911cc63 /drivers/mtd/devices/lart.c | |
| parent | f12a9473283e68ae708e9ada37cb352ea2652397 (diff) | |
| download | op-kernel-dev-4c1e6b2ce13b154a4a69cee220c98976f4b784df.zip op-kernel-dev-4c1e6b2ce13b154a4a69cee220c98976f4b784df.tar.gz | |
mtd: lart: Prevent a read from mtd->eraseregions[-1]
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd/devices/lart.c')
| -rw-r--r-- | drivers/mtd/devices/lart.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/mtd/devices/lart.c b/drivers/mtd/devices/lart.c index 578de1c..f4359fe 100644 --- a/drivers/mtd/devices/lart.c +++ b/drivers/mtd/devices/lart.c @@ -393,7 +393,8 @@ static int flash_erase (struct mtd_info *mtd,struct erase_info *instr) * erase range is aligned with the erase size which is in * effect here. */ - if (instr->addr & (mtd->eraseregions[i].erasesize - 1)) return (-EINVAL); + if (i < 0 || (instr->addr & (mtd->eraseregions[i].erasesize - 1))) + return -EINVAL; /* Remember the erase region we start on */ first = i; @@ -409,7 +410,8 @@ static int flash_erase (struct mtd_info *mtd,struct erase_info *instr) i--; /* is the end aligned on a block boundary? */ - if ((instr->addr + instr->len) & (mtd->eraseregions[i].erasesize - 1)) return (-EINVAL); + if (i < 0 || ((instr->addr + instr->len) & (mtd->eraseregions[i].erasesize - 1))) + return -EINVAL; addr = instr->addr; len = instr->len; |
