diff options
| author | Haavard Skinnemoen <haavard.skinnemoen@atmel.com> | 2008-10-05 15:16:59 +0200 |
|---|---|---|
| committer | Haavard Skinnemoen <haavard.skinnemoen@atmel.com> | 2008-10-05 20:39:21 +0200 |
| commit | ca55f46e13dd07b029b0a3d64637f983a6627b23 (patch) | |
| tree | 4451919320800974f1a937fe5ee25552307166a6 /drivers/mmc | |
| parent | 65e8b083fc8ec303499baa1924ae032d46d29990 (diff) | |
| download | op-kernel-dev-ca55f46e13dd07b029b0a3d64637f983a6627b23.zip op-kernel-dev-ca55f46e13dd07b029b0a3d64637f983a6627b23.tar.gz | |
atmel-mci: Don't overwrite error bits when NOTBUSY is set
After a data error, we wait for the NOTBUSY bit to be set so that we can
be sure the data transfer is completely finished. However, when NOTBUSY
is set, the interrupt handler copies the contents of SR into
data_status, overwriting any error bits we may have detected earlier.
To avoid this, initialize data_status to 0 before starting a request, and
don't overwrite it unless it still contains 0.
Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Diffstat (limited to 'drivers/mmc')
| -rw-r--r-- | drivers/mmc/host/atmel-mci.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index d45dfa2..02529af 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -694,6 +694,7 @@ static void atmci_start_request(struct atmel_mci *host, host->pending_events = 0; host->completed_events = 0; + host->data_status = 0; if (host->need_reset) { mci_writel(host, CR, MCI_CR_SWRST); @@ -1408,7 +1409,8 @@ static irqreturn_t atmci_interrupt(int irq, void *dev_id) if (pending & MCI_NOTBUSY) { mci_writel(host, IDR, ATMCI_DATA_ERROR_FLAGS | MCI_NOTBUSY); - host->data_status = status; + if (!host->data_status) + host->data_status = status; smp_wmb(); atmci_set_pending(host, EVENT_DATA_COMPLETE); tasklet_schedule(&host->tasklet); |
