summaryrefslogtreecommitdiffstats
path: root/drivers/mmc
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-11-15 21:56:41 +0300
committerUlf Hansson <ulf.hansson@linaro.org>2014-11-26 14:31:01 +0100
commit9e2a0c96efab30c85367176d1fc2c04906676458 (patch)
treedf21a221d9b5a7b42cc3142d33ae0e177bc0c337 /drivers/mmc
parentecb89f2f5f3e771108a5595b0b4d1a1a974cc926 (diff)
downloadop-kernel-dev-9e2a0c96efab30c85367176d1fc2c04906676458.zip
op-kernel-dev-9e2a0c96efab30c85367176d1fc2c04906676458.tar.gz
mmc: toshsd: move dereference below check for NULL
We check for NULL pointers after dereferencing so it's too late. Oddly enough, Smatch misses this code but complains about the caller passing NULL pointers to this function: drivers/mmc/host/toshsd.c:389 toshsd_irq() error: we previously assumed 'host->cmd' could be null (see line 349) Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r--drivers/mmc/host/toshsd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mmc/host/toshsd.c b/drivers/mmc/host/toshsd.c
index edb06d6..4666262 100644
--- a/drivers/mmc/host/toshsd.c
+++ b/drivers/mmc/host/toshsd.c
@@ -206,14 +206,14 @@ static irqreturn_t toshsd_thread_irq(int irq, void *dev_id)
static void toshsd_cmd_irq(struct toshsd_host *host)
{
struct mmc_command *cmd = host->cmd;
- u8 *buf = (u8 *) cmd->resp;
+ u8 *buf;
u16 data;
if (!host->cmd) {
dev_warn(&host->pdev->dev, "Spurious CMD irq\n");
return;
}
-
+ buf = (u8 *)cmd->resp;
host->cmd = NULL;
if (cmd->flags & MMC_RSP_PRESENT && cmd->flags & MMC_RSP_136) {
OpenPOWER on IntegriCloud