diff options
author | Adrian Hunter <adrian.hunter@intel.com> | 2016-06-29 16:24:38 +0300 |
---|---|---|
committer | Ulf Hansson <ulf.hansson@linaro.org> | 2016-07-25 10:34:45 +0200 |
commit | 07c161bcd7ff6d119f828402a776c9e43a50a851 (patch) | |
tree | 07b5c586978817d1a955cc72c51e1e148af6dea2 /drivers/mmc/host/sdhci.c | |
parent | 8842fd17b655c19fa2f50cae5924b35769411da5 (diff) | |
download | op-kernel-dev-07c161bcd7ff6d119f828402a776c9e43a50a851.zip op-kernel-dev-07c161bcd7ff6d119f828402a776c9e43a50a851.tar.gz |
mmc: sdhci: sdhci_execute_tuning() must delete timer
sdhci_send_command() starts a timer to catch cases where the host
controller fails. The timer is normally deleted when the request completes,
but in the case of sdhci_execute_tuning() the request is handled
differently and the timer is left running. This goes unnoticed because
tuning is done before another command so the timer gets reset then.
That should not be relied upon, so make sdhci_execute_tuning() delete the
timer.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc/host/sdhci.c')
-rw-r--r-- | drivers/mmc/host/sdhci.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 6c8cc1a..2ee8bfa 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2057,6 +2057,7 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode) sdhci_send_command(host, &cmd); host->cmd = NULL; + sdhci_del_timer(host, &mrq); spin_unlock_irqrestore(&host->lock, flags); /* Wait for Buffer Read Ready interrupt */ |