summaryrefslogtreecommitdiffstats
path: root/drivers/misc
diff options
context:
space:
mode:
authorCyrill Gorcunov <gorcunov@gmail.com>2007-10-02 13:30:07 -0700
committerPaul Mackerras <paulus@samba.org>2007-10-03 12:02:44 +1000
commit5f725fe92cc2e75892b237e863d5f695fb634bb2 (patch)
tree6905d531858c0b3716220734540e25e75b16fe68 /drivers/misc
parent7472fd36a87e84c2819066543224285a6ab79ffc (diff)
downloadop-kernel-dev-5f725fe92cc2e75892b237e863d5f695fb634bb2.zip
op-kernel-dev-5f725fe92cc2e75892b237e863d5f695fb634bb2.tar.gz
[POWERPC] Sky Cpu and Nexus: check for create_proc_entry ret code
Adds checking of create_proc_entry call to prevent possible NULL pointer usage. Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Kumar Gala <galak@gate.crashing.org> Cc: Brian Waite <waite@skycomputers.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'drivers/misc')
-rw-r--r--drivers/misc/hdpuftrs/hdpu_nexus.c14
1 files changed, 12 insertions, 2 deletions
diff --git a/drivers/misc/hdpuftrs/hdpu_nexus.c b/drivers/misc/hdpuftrs/hdpu_nexus.c
index 01bc917..cc81853 100644
--- a/drivers/misc/hdpuftrs/hdpu_nexus.c
+++ b/drivers/misc/hdpuftrs/hdpu_nexus.c
@@ -78,10 +78,20 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
}
hdpu_slot_id = create_proc_entry("sky_slot_id", 0666, &proc_root);
- hdpu_slot_id->read_proc = hdpu_slot_id_read;
+ if (!hdpu_slot_id) {
+ printk(KERN_WARNING "sky_nexus: "
+ "Unable to create proc dir entry: sky_slot_id\n");
+ } else {
+ hdpu_slot_id->read_proc = hdpu_slot_id_read;
+ }
hdpu_chassis_id = create_proc_entry("sky_chassis_id", 0666, &proc_root);
- hdpu_chassis_id->read_proc = hdpu_chassis_id_read;
+ if (!hdpu_chassis_id) {
+ printk(KERN_WARNING "sky_nexus: "
+ "Unable to create proc dir entry: sky_chassis_id\n");
+ } else {
+ hdpu_chassis_id->read_proc = hdpu_chassis_id_read;
+ }
return 0;
}
OpenPOWER on IntegriCloud