summaryrefslogtreecommitdiffstats
path: root/drivers/mfd
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2010-10-13 10:44:39 +0800
committerSamuel Ortiz <sameo@linux.intel.com>2010-10-29 00:30:29 +0200
commita8d6aa08dd3e004df6a6e63a61698d834a191ad3 (patch)
treeaaad867dccdf9d2b7e04c6bd73834882428b5a41 /drivers/mfd
parent7745cc8c3b977203c1b7483c09d05b58c8e88728 (diff)
downloadop-kernel-dev-a8d6aa08dd3e004df6a6e63a61698d834a191ad3.zip
op-kernel-dev-a8d6aa08dd3e004df6a6e63a61698d834a191ad3.tar.gz
mfd: Fix off-by-one value range checking for tps6507x
If bytes == (TPS6507X_MAX_REGISTER + 1), we have a buffer overflow when doing memcpy(&msg[1], src, bytes). Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/mfd')
-rw-r--r--drivers/mfd/tps6507x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c
index fc01976..33ba772 100644
--- a/drivers/mfd/tps6507x.c
+++ b/drivers/mfd/tps6507x.c
@@ -68,7 +68,7 @@ static int tps6507x_i2c_write_device(struct tps6507x_dev *tps6507x, char reg,
u8 msg[TPS6507X_MAX_REGISTER + 1];
int ret;
- if (bytes > (TPS6507X_MAX_REGISTER + 1))
+ if (bytes > TPS6507X_MAX_REGISTER)
return -EINVAL;
msg[0] = reg;
OpenPOWER on IntegriCloud