summaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-01-15 07:32:19 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-01-16 12:38:00 -0200
commite9ae4d4f028cd9ff9e7d06430cc678d7926df9e0 (patch)
tree81830cbe62476f40f46cdbc06af1f1745a4d14c8 /drivers/media
parent0397e4505910b44be0066d1b2ce201f0c03bae4f (diff)
downloadop-kernel-dev-e9ae4d4f028cd9ff9e7d06430cc678d7926df9e0.zip
op-kernel-dev-e9ae4d4f028cd9ff9e7d06430cc678d7926df9e0.tar.gz
[media] tlg2300: fix up check_firmware() return
The caller doesn't check the return value of check_firmware() but static checkers complain. It currently returns negative error codes, or zero or greater on success but since the return type is boolean the values are truncated to one or zero. I've changed it to return an int, negative on error and zero on success. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/video/tlg2300/pd-main.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/video/tlg2300/pd-main.c b/drivers/media/video/tlg2300/pd-main.c
index 129f135..c096b3f 100644
--- a/drivers/media/video/tlg2300/pd-main.c
+++ b/drivers/media/video/tlg2300/pd-main.c
@@ -374,7 +374,7 @@ static inline void set_map_flags(struct poseidon *pd, struct usb_device *udev)
}
#endif
-static bool check_firmware(struct usb_device *udev, int *down_firmware)
+static int check_firmware(struct usb_device *udev, int *down_firmware)
{
void *buf;
int ret;
@@ -398,7 +398,7 @@ static bool check_firmware(struct usb_device *udev, int *down_firmware)
*down_firmware = 1;
return firmware_download(udev);
}
- return ret;
+ return 0;
}
static int poseidon_probe(struct usb_interface *interface,
OpenPOWER on IntegriCloud