summaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorHans Petter Selasky <hselasky@c2i.net>2011-05-23 08:09:18 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2011-06-01 12:20:57 -0300
commit67e27c741339faedcc8e9c2c613487745d1c4b8b (patch)
tree45a46cfc93065f46719c386ea5f42e4b87ff6f67 /drivers/media
parent6c20c635b8bb110d5c610bf19233462dcfa3b39b (diff)
downloadop-kernel-dev-67e27c741339faedcc8e9c2c613487745d1c4b8b.zip
op-kernel-dev-67e27c741339faedcc8e9c2c613487745d1c4b8b.tar.gz
[media] Make nchg variable signed because the code compares this variable against negative values
The sonixj driver compares the value for nchg with: if (sd->nchg < -6 || sd->nchg >= 12) { With u8, negative values won't work. Signed-off-by: Hans Petter Selasky <hselasky@c2i.net> Acked-by: Jean-Francois Moine <moinejf@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/video/gspca/sonixj.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c
index 6415aff..81b8a60 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -60,7 +60,7 @@ struct sd {
u32 pktsz; /* (used by pkt_scan) */
u16 npkt;
- u8 nchg;
+ s8 nchg;
s8 short_mark;
u8 quality; /* image quality */
OpenPOWER on IntegriCloud