diff options
| author | Hans Verkuil <hverkuil@xs4all.nl> | 2018-04-20 04:13:53 -0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-05-09 16:15:06 -0400 |
| commit | f6b6631478d7708d86dc0b268671d5191b96946e (patch) | |
| tree | 1949fb1fe4fcddc6f106c81e1029e3f1c3dde1c9 /drivers/media | |
| parent | 8516529ee5b6a56ddd841ea3817ab863fb6d6217 (diff) | |
| download | op-kernel-dev-f6b6631478d7708d86dc0b268671d5191b96946e.zip op-kernel-dev-f6b6631478d7708d86dc0b268671d5191b96946e.tar.gz | |
media: cec-gpio: use GPIOD_OUT_HIGH_OPEN_DRAIN
This driver needs a pull up output GPIO, but devm_gpiod_get() is called
with GPIOD_IN. This apparently works fine for the RPi3 where the DT
correctly specifies a pull up GPIO, but on the i.MX6 it also needs to
be specified with devm_gpiod_get().
Reported-by: Henrik Mau <Henrik.Mau@linn.co.uk>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media')
| -rw-r--r-- | drivers/media/platform/cec-gpio/cec-gpio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/cec-gpio/cec-gpio.c b/drivers/media/platform/cec-gpio/cec-gpio.c index f1f28cf..69f8242 100644 --- a/drivers/media/platform/cec-gpio/cec-gpio.c +++ b/drivers/media/platform/cec-gpio/cec-gpio.c @@ -158,7 +158,7 @@ static int cec_gpio_probe(struct platform_device *pdev) cec->dev = dev; - cec->cec_gpio = devm_gpiod_get(dev, "cec", GPIOD_IN); + cec->cec_gpio = devm_gpiod_get(dev, "cec", GPIOD_OUT_HIGH_OPEN_DRAIN); if (IS_ERR(cec->cec_gpio)) return PTR_ERR(cec->cec_gpio); cec->cec_irq = gpiod_to_irq(cec->cec_gpio); |
