summaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorArchit Taneja <archit@ti.com>2014-02-18 10:24:07 -0300
committerMauro Carvalho Chehab <m.chehab@samsung.com>2014-04-07 09:41:57 -0300
commit772a7b7ae1ed8dcb829fffa3e535725f2ecdaa94 (patch)
treefd38b7b92a1fed241bfbb339e9cd8356d26aff1a /drivers/media
parentdb476163da7b53433ea1c4080625fa56daf6fdda (diff)
downloadop-kernel-dev-772a7b7ae1ed8dcb829fffa3e535725f2ecdaa94.zip
op-kernel-dev-772a7b7ae1ed8dcb829fffa3e535725f2ecdaa94.tar.gz
[media] v4l: ti-vpe: Use video_device_release_empty
The video_device struct is currently embedded in the driver data struct vpe_dev. A vpe_dev instance is allocated by the driver, and the memory for the vfd is a part of this struct. The v4l2 core, however, manages the removal of the vfd region, through the video_device's .release() op, which currently is the helper video_device_release. This causes memory corruption, and leads to issues when we try to re-insert the vpe module. Use the video_device_release_empty helper function instead. Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Archit Taneja <archit@ti.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/platform/ti-vpe/vpe.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c
index f3143ac..578c0c6 100644
--- a/drivers/media/platform/ti-vpe/vpe.c
+++ b/drivers/media/platform/ti-vpe/vpe.c
@@ -2005,7 +2005,7 @@ static struct video_device vpe_videodev = {
.fops = &vpe_fops,
.ioctl_ops = &vpe_ioctl_ops,
.minor = -1,
- .release = video_device_release,
+ .release = video_device_release_empty,
.vfl_dir = VFL_DIR_M2M,
};
OpenPOWER on IntegriCloud