summaryrefslogtreecommitdiffstats
path: root/drivers/media/usb/em28xx
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2016-05-09 05:22:55 -0300
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2016-06-10 08:29:40 -0300
commite44c153b30c9a0580fc2b5a93f3c6d593def2278 (patch)
tree14d26e4daea500ed68ff19e754d4facaede626e7 /drivers/media/usb/em28xx
parent917d11a4e0c8c9e3d375a7baa945fe0da6b15f88 (diff)
downloadop-kernel-dev-e44c153b30c9a0580fc2b5a93f3c6d593def2278.zip
op-kernel-dev-e44c153b30c9a0580fc2b5a93f3c6d593def2278.tar.gz
[media] em28xx-i2c: rt_mutex_trylock() returns zero on failure
The code is checking for negative returns but it should be checking for zero. Fixes: aab3125c43d8 ('[media] em28xx: add support for registering multiple i2c buses') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/usb/em28xx')
-rw-r--r--drivers/media/usb/em28xx/em28xx-i2c.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
index a19b5c8..1a9e1e5 100644
--- a/drivers/media/usb/em28xx/em28xx-i2c.c
+++ b/drivers/media/usb/em28xx/em28xx-i2c.c
@@ -507,9 +507,8 @@ static int em28xx_i2c_xfer(struct i2c_adapter *i2c_adap,
if (dev->disconnected)
return -ENODEV;
- rc = rt_mutex_trylock(&dev->i2c_bus_lock);
- if (rc < 0)
- return rc;
+ if (!rt_mutex_trylock(&dev->i2c_bus_lock))
+ return -EAGAIN;
/* Switch I2C bus if needed */
if (bus != dev->cur_i2c_bus &&
OpenPOWER on IntegriCloud