diff options
| author | Peter Senna Tschudin <peter.senna@gmail.com> | 2012-09-04 08:05:05 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-09-23 13:40:14 -0300 |
| commit | 6ea7cf7680d872d199ae3d87c5897def3b8da1f7 (patch) | |
| tree | 4835c6aa398a49b66988158cfd0bd9848b03ed19 /drivers/media/rc | |
| parent | 24e527a0e7b23ca0158a4251157d234e156f88ca (diff) | |
| download | op-kernel-dev-6ea7cf7680d872d199ae3d87c5897def3b8da1f7.zip op-kernel-dev-6ea7cf7680d872d199ae3d87c5897def3b8da1f7.tar.gz | |
[media] drivers/media/rc/redrat3.c: fix error return code
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/rc')
| -rw-r--r-- | drivers/media/rc/redrat3.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c index 2878b0e..49731b1 100644 --- a/drivers/media/rc/redrat3.c +++ b/drivers/media/rc/redrat3.c @@ -1217,9 +1217,10 @@ static int __devinit redrat3_dev_probe(struct usb_interface *intf, rr3->carrier = 38000; rr3->rc = redrat3_init_rc_dev(rr3); - if (!rr3->rc) + if (!rr3->rc) { + retval = -ENOMEM; goto error; - + } setup_timer(&rr3->rx_timeout, redrat3_rx_timeout, (unsigned long)rr3); /* we can register the device now, as it is ready */ |
