diff options
author | Bhumika Goyal <bhumirks@gmail.com> | 2016-12-11 07:52:32 -0200 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2017-02-03 09:21:50 -0200 |
commit | cebb31c8b5fdea701b94b4a1664b50b7705736eb (patch) | |
tree | f40b4ecb9e73d9869944ea45533846921dffb3d8 /drivers/media/platform/xilinx | |
parent | 8726650a1a6c817333dd5933032244540c88bb21 (diff) | |
download | op-kernel-dev-cebb31c8b5fdea701b94b4a1664b50b7705736eb.zip op-kernel-dev-cebb31c8b5fdea701b94b4a1664b50b7705736eb.tar.gz |
[media] media: platform: xilinx: xilinx-tpg: constify v4l2_subdev_* structures
v4l2_subdev_{core/pad/video}_ops structures are stored in the
fields of the v4l2_subdev_ops structure which are of type const.
Also, v4l2_subdev_ops structure is passed to a function
having its argument of type const. As these structures are never
modified, so declare them as const.
Done using Coccinelle: (One of the scripts used)
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct v4l2_subdev_video_ops i@p = {...};
@ok1@
identifier r1.i;
position p;
struct v4l2_subdev_ops obj;
@@
obj.video=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct v4l2_subdev_video_ops i;
File size before:
text data bss dec hex filename
6170 2752 144 9066 236a media/platform/xilinx/xilinx-tpg.o
File size after:
text data bss dec hex filename
6666 2384 8 9058 2362 media/platform/xilinx/xilinx-tpg.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/platform/xilinx')
-rw-r--r-- | drivers/media/platform/xilinx/xilinx-tpg.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c b/drivers/media/platform/xilinx/xilinx-tpg.c index 2ec1f6c..9c49d1d 100644 --- a/drivers/media/platform/xilinx/xilinx-tpg.c +++ b/drivers/media/platform/xilinx/xilinx-tpg.c @@ -460,21 +460,21 @@ static const struct v4l2_ctrl_ops xtpg_ctrl_ops = { .s_ctrl = xtpg_s_ctrl, }; -static struct v4l2_subdev_core_ops xtpg_core_ops = { +static const struct v4l2_subdev_core_ops xtpg_core_ops = { }; -static struct v4l2_subdev_video_ops xtpg_video_ops = { +static const struct v4l2_subdev_video_ops xtpg_video_ops = { .s_stream = xtpg_s_stream, }; -static struct v4l2_subdev_pad_ops xtpg_pad_ops = { +static const struct v4l2_subdev_pad_ops xtpg_pad_ops = { .enum_mbus_code = xvip_enum_mbus_code, .enum_frame_size = xtpg_enum_frame_size, .get_fmt = xtpg_get_format, .set_fmt = xtpg_set_format, }; -static struct v4l2_subdev_ops xtpg_ops = { +static const struct v4l2_subdev_ops xtpg_ops = { .core = &xtpg_core_ops, .video = &xtpg_video_ops, .pad = &xtpg_pad_ops, |