summaryrefslogtreecommitdiffstats
path: root/drivers/media/i2c/m5mols
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2012-08-18 17:25:59 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-09-14 11:08:40 -0300
commitb25b895805dd415f218cfd4892d17aeb2db425f7 (patch)
tree2efa59ed594532e51ef9427f822e00b2a15df10a /drivers/media/i2c/m5mols
parent780d61704cf62a51c06c0ca8210d0282591e00b2 (diff)
downloadop-kernel-dev-b25b895805dd415f218cfd4892d17aeb2db425f7.zip
op-kernel-dev-b25b895805dd415f218cfd4892d17aeb2db425f7.tar.gz
[media] m5mols: introduce missing initialization
The result of one call to a function is tested, and then at the second call to the same function, the previous result, and not the current result, is tested again. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression ret; identifier f; statement S1,S2; @@ *ret = f(...); if (\(ret != 0\|ret < 0\|ret == NULL\)) S1 ... when any *f(...); if (\(ret != 0\|ret < 0\|ret == NULL\)) S2 // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/i2c/m5mols')
-rw-r--r--drivers/media/i2c/m5mols/m5mols_core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/m5mols/m5mols_core.c b/drivers/media/i2c/m5mols/m5mols_core.c
index ac7d28b..0f521f5 100644
--- a/drivers/media/i2c/m5mols/m5mols_core.c
+++ b/drivers/media/i2c/m5mols/m5mols_core.c
@@ -937,7 +937,7 @@ static int __devinit m5mols_probe(struct i2c_client *client,
if (!ret)
ret = m5mols_init_controls(sd);
- m5mols_sensor_power(info, false);
+ ret = m5mols_sensor_power(info, false);
if (!ret)
return 0;
out_me:
OpenPOWER on IntegriCloud