diff options
| author | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2014-10-30 07:16:57 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2014-11-03 15:53:15 -0200 |
| commit | f2dd851ff19412bdc80471048283edbb465f812e (patch) | |
| tree | 7b0309ce8ee16c0d310db1ad8edfea677e8f846d /drivers/media/firewire | |
| parent | 6ed9b28504326f8cf542e6b68245b2f7ce009216 (diff) | |
| download | op-kernel-dev-f2dd851ff19412bdc80471048283edbb465f812e.zip op-kernel-dev-f2dd851ff19412bdc80471048283edbb465f812e.tar.gz | |
[media] fix a warning on avr32 arch
X-Patchwork-Delegate: m.chehab@samsung.com
on avr32 arch, those warnings happen:
drivers/media/firewire/firedtv-fw.c: In function 'node_update':
drivers/media/firewire/firedtv-fw.c:329: warning: comparison is always true due to limited range of data type
In this particular case, the signal is desired, as the isochannel
var can be initalized with -1 inside the driver.
So, change the type to s8, to avoid issues on archs where char
is unsigned.
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Reviewed-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/firewire')
| -rw-r--r-- | drivers/media/firewire/firedtv.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/firewire/firedtv.h b/drivers/media/firewire/firedtv.h index c2ba085..346a85b 100644 --- a/drivers/media/firewire/firedtv.h +++ b/drivers/media/firewire/firedtv.h @@ -96,7 +96,7 @@ struct firedtv { enum model_type type; char subunit; - char isochannel; + s8 isochannel; struct fdtv_ir_context *ir_context; fe_sec_voltage_t voltage; |
