diff options
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-21 09:40:22 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-21 10:03:53 -0300 |
| commit | 05ad412a63d66175f8f5a3d08894cf3f1d118cbc (patch) | |
| tree | f11eeea793de25cf5be1a02ff54f711f97ed60e3 /drivers/media/common/siano/smscoreapi.c | |
| parent | 28a59df4d7cb8f749ba92ad304df4063ccf108fd (diff) | |
| download | op-kernel-dev-05ad412a63d66175f8f5a3d08894cf3f1d118cbc.zip op-kernel-dev-05ad412a63d66175f8f5a3d08894cf3f1d118cbc.tar.gz | |
[media] siano: Fix the remaining checkpatch.pl compliants
Fix all other remaining checkpatch.pl compliants on the Siano driver,
except for the 80-cols (soft) limit. Those are harder to fix, and
probably not worth to do right now.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/common/siano/smscoreapi.c')
| -rw-r--r-- | drivers/media/common/siano/smscoreapi.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c index 19e7a5f..e7fc4de 100644 --- a/drivers/media/common/siano/smscoreapi.c +++ b/drivers/media/common/siano/smscoreapi.c @@ -57,8 +57,8 @@ struct smscore_client_t { struct list_head entry; struct smscore_device_t *coredev; void *context; - struct list_head idlist; - onresponse_t onresponse_handler; + struct list_head idlist; + onresponse_t onresponse_handler; onremove_t onremove_handler; }; @@ -874,7 +874,7 @@ int smscore_configure_board(struct smscore_device_t *coredev) * sets initial device mode and notifies client hotplugs that device is ready * * @param coredev pointer to a coredev object returned by - * smscore_register_device + * smscore_register_device * * @return 0 on success, <0 on error. */ @@ -961,7 +961,7 @@ static int smscore_load_firmware_family2(struct smscore_device_t *coredev, while (size && rc >= 0) { struct sms_data_download *data_msg = (struct sms_data_download *) msg; - int payload_size = min((int) size, SMS_MAX_PAYLOAD_SIZE); + int payload_size = min_t(int, size, SMS_MAX_PAYLOAD_SIZE); SMS_INIT_MSG(&msg->x_msg_header, MSG_SMS_DATA_DOWNLOAD_REQ, (u16)(sizeof(struct sms_msg_hdr) + @@ -1225,8 +1225,7 @@ void smscore_unregister_device(struct smscore_device_t *coredev) if (num_buffers == coredev->num_buffers) break; if (++retry > 10) { - sms_info("exiting although " - "not all buffers released."); + sms_info("exiting although not all buffers released."); break; } @@ -1279,8 +1278,8 @@ static int smscore_detect_mode(struct smscore_device_t *coredev) coredev, msg, msg->msg_length, &coredev->version_ex_done); if (rc < 0) - sms_err("MSG_SMS_GET_VERSION_EX_REQ failed " - "second try, rc %d", rc); + sms_err("MSG_SMS_GET_VERSION_EX_REQ failed second try, rc %d", + rc); } else rc = -ETIME; } |
