summaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2014-05-06 09:36:08 +1000
committerNeilBrown <neilb@suse.de>2014-05-06 09:49:31 +1000
commit0f62fb220aa4ebabe8547d3a9ce4a16d3c045f21 (patch)
tree7357293dea01b968a18a745640c8c15f93061ccc /drivers/md
parentcc13b1d1500656a20e41960668f3392dda9fa6e2 (diff)
downloadop-kernel-dev-0f62fb220aa4ebabe8547d3a9ce4a16d3c045f21.zip
op-kernel-dev-0f62fb220aa4ebabe8547d3a9ce4a16d3c045f21.tar.gz
md: avoid possible spinning md thread at shutdown.
If an md array with externally managed metadata (e.g. DDF or IMSM) is in use, then we should not set safemode==2 at shutdown because: 1/ this is ineffective: user-space need to be involved in any 'safemode' handling, 2/ The safemode management code doesn't cope with safemode==2 on external metadata and md_check_recover enters an infinite loop. Even at shutdown, an infinite-looping process can be problematic, so this could cause shutdown to hang. Cc: stable@vger.kernel.org (any kernel) Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/md.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 8fda38d..237b7e0 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8516,7 +8516,8 @@ static int md_notify_reboot(struct notifier_block *this,
if (mddev_trylock(mddev)) {
if (mddev->pers)
__md_stop_writes(mddev);
- mddev->safemode = 2;
+ if (mddev->persistent)
+ mddev->safemode = 2;
mddev_unlock(mddev);
}
need_delay = 1;
OpenPOWER on IntegriCloud