summaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorJonathan Brassow <jbrassow@redhat.com>2012-05-22 13:55:31 +1000
committerNeilBrown <neilb@suse.de>2012-05-22 13:55:31 +1000
commitc32fb9e7ecee25a5b6a45bf968dfef76f323e185 (patch)
tree5de381a4d0c926c480d0e7244975a81450f8ecce /drivers/md
parent81f382f9e0b25ef56b1c0283c900b86b91a5e4c7 (diff)
downloadop-kernel-dev-c32fb9e7ecee25a5b6a45bf968dfef76f323e185.zip
op-kernel-dev-c32fb9e7ecee25a5b6a45bf968dfef76f323e185.tar.gz
DM RAID: Use md_error() in place of simply setting Faulty bit
When encountering an error while reading the superblock, call md_error. We are currently setting the 'Faulty' bit on one of the array devices when an error is encountered while reading the superblock of a dm-raid array. We should be calling md_error(), as it handles the error more completely. Signed-off-by: Jonathan Brassow <jbrassow@redhat.com> Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/dm-raid.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index f1797c4..017c34d 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -603,7 +603,7 @@ static int read_disk_sb(struct md_rdev *rdev, int size)
if (!sync_page_io(rdev, 0, size, rdev->sb_page, READ, 1)) {
DMERR("Failed to read superblock of device at position %d",
rdev->raid_disk);
- set_bit(Faulty, &rdev->flags);
+ md_error(rdev->mddev, rdev);
return -EINVAL;
}
OpenPOWER on IntegriCloud