summaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2014-05-28 13:39:22 +1000
committerNeilBrown <neilb@suse.de>2014-05-29 16:59:46 +1000
commit8b32bf5e37328c0ef267bc95d73b55e52f72ac77 (patch)
tree6f85ee28bfe2a09652577bf332ea07c01be1361d /drivers/md
parent67f455486d2ea20b2d94d6adf5b9b783d079e321 (diff)
downloadop-kernel-dev-8b32bf5e37328c0ef267bc95d73b55e52f72ac77.zip
op-kernel-dev-8b32bf5e37328c0ef267bc95d73b55e52f72ac77.tar.gz
md: md_clear_badblocks should return an error code on failure.
Julia Lawall and coccinelle report that md_clear_badblocks always returns 0, despite appearing to have an error path. The error path really should return an error code. ENOSPC is reasonably appropriate. Reported-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/md.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 0ddf389..3484685 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8343,7 +8343,7 @@ static int md_clear_badblocks(struct badblocks *bb, sector_t s, int sectors)
if (a < s) {
/* we need to split this range */
if (bb->count >= MD_MAX_BADBLOCKS) {
- rv = 0;
+ rv = -ENOSPC;
goto out;
}
memmove(p+lo+1, p+lo, (bb->count - lo) * 8);
OpenPOWER on IntegriCloud