summaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorDmitry Monakhov <dmonakhov@openvz.org>2007-10-19 22:38:37 +0100
committerAlasdair G Kergon <agk@redhat.com>2007-10-20 02:00:59 +0100
commit55b42c5ae9c048de25233434afc7b71b01bee9e6 (patch)
tree872a9e8cd132f89ed29ba242e53f5877702cbb17 /drivers/md
parent027d50f92ea26fd065aeb141ebfcbbbe010825e3 (diff)
downloadop-kernel-dev-55b42c5ae9c048de25233434afc7b71b01bee9e6.zip
op-kernel-dev-55b42c5ae9c048de25233434afc7b71b01bee9e6.tar.gz
dm crypt: drop device ref in ctr error path
Add a missing 'dm_put_device' in an error path in crypt target constructor. Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> Signed-off-by: Milan Broz <mbroz@redhat.com> Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/dm-crypt.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c
index 64fee90..ecd9ef0 100644
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -861,7 +861,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv)
cc->iv_mode = kmalloc(strlen(ivmode) + 1, GFP_KERNEL);
if (!cc->iv_mode) {
ti->error = "Error kmallocing iv_mode string";
- goto bad5;
+ goto bad_iv_mode;
}
strcpy(cc->iv_mode, ivmode);
} else
@@ -870,6 +870,8 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv)
ti->private = cc;
return 0;
+bad_iv_mode:
+ dm_put_device(ti, cc->dev);
bad5:
bioset_free(cc->bs);
bad_bs:
OpenPOWER on IntegriCloud