summaryrefslogtreecommitdiffstats
path: root/drivers/md/dm-thin.c
diff options
context:
space:
mode:
authorMike Snitzer <snitzer@redhat.com>2014-02-06 06:08:56 -0500
committerMike Snitzer <snitzer@redhat.com>2014-02-17 11:00:05 -0500
commit4d1662a30dde6e545086fe0e8fd7e474c4e0b639 (patch)
tree0845a7da235aceef3400a6ad7c6ab49b9c4c7ed9 /drivers/md/dm-thin.c
parent80ae49aaed32af72630251eb06161b15cde15ac8 (diff)
downloadop-kernel-dev-4d1662a30dde6e545086fe0e8fd7e474c4e0b639.zip
op-kernel-dev-4d1662a30dde6e545086fe0e8fd7e474c4e0b639.tar.gz
dm thin: avoid metadata commit if a pool's thin devices haven't changed
Commit 905e51b ("dm thin: commit outstanding data every second") introduced a periodic commit. This commit occurs regardless of whether any thin devices have made changes. Fix the periodic commit to check if any of a pool's thin devices have changed using dm_pool_changed_this_transaction(). Reported-by: Alexander Larsson <alexl@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com> Acked-by: Joe Thornber <ejt@redhat.com> Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/md/dm-thin.c')
-rw-r--r--drivers/md/dm-thin.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index faaf944..d501e43 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -1357,7 +1357,8 @@ static void process_deferred_bios(struct pool *pool)
bio_list_init(&pool->deferred_flush_bios);
spin_unlock_irqrestore(&pool->lock, flags);
- if (bio_list_empty(&bios) && !need_commit_due_to_time(pool))
+ if (bio_list_empty(&bios) &&
+ !(dm_pool_changed_this_transaction(pool->pmd) && need_commit_due_to_time(pool)))
return;
if (commit(pool)) {
OpenPOWER on IntegriCloud