diff options
| author | Nikolay Borisov <kernel@kyup.com> | 2015-12-17 18:03:35 +0200 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2015-12-17 15:47:20 -0500 |
| commit | 18d03e8c25f173f4107a40d0b8c24defb6ed69f3 (patch) | |
| tree | 6cdaea8c63311344d76035ec82320fd337c71d6f /drivers/md/dm-thin.c | |
| parent | 512167788a6fe9481a33a3cce5f80b684631a1bb (diff) | |
| download | op-kernel-dev-18d03e8c25f173f4107a40d0b8c24defb6ed69f3.zip op-kernel-dev-18d03e8c25f173f4107a40d0b8c24defb6ed69f3.tar.gz | |
dm thin: fix race condition when destroying thin pool workqueue
When a thin pool is being destroyed delayed work items are
cancelled using cancel_delayed_work(), which doesn't guarantee that on
return the delayed item isn't running. This can cause the work item to
requeue itself on an already destroyed workqueue. Fix this by using
cancel_delayed_work_sync() which guarantees that on return the work item
is not running anymore.
Fixes: 905e51b39a555 ("dm thin: commit outstanding data every second")
Fixes: 85ad643b7e7e5 ("dm thin: add timeout to stop out-of-data-space mode holding IO forever")
Signed-off-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/md/dm-thin.c')
| -rw-r--r-- | drivers/md/dm-thin.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 63903a5..a1cc797 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -3453,8 +3453,8 @@ static void pool_postsuspend(struct dm_target *ti) struct pool_c *pt = ti->private; struct pool *pool = pt->pool; - cancel_delayed_work(&pool->waker); - cancel_delayed_work(&pool->no_space_timeout); + cancel_delayed_work_sync(&pool->waker); + cancel_delayed_work_sync(&pool->no_space_timeout); flush_workqueue(pool->wq); (void) commit(pool); } |
