diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2011-09-25 23:26:15 +0100 |
|---|---|---|
| committer | Alasdair G Kergon <agk@redhat.com> | 2011-09-25 23:26:15 +0100 |
| commit | 68e58a294fb26f692697179e3f3ecf88dd8cb97c (patch) | |
| tree | 4576ce77f692c4acf85883b5d18127c5806bdf64 /drivers/md/dm-flakey.c | |
| parent | d93dc5c4478c1fd5de85a3e8aece9aad7bbae044 (diff) | |
| download | op-kernel-dev-68e58a294fb26f692697179e3f3ecf88dd8cb97c.zip op-kernel-dev-68e58a294fb26f692697179e3f3ecf88dd8cb97c.tar.gz | |
dm: flakey fix corrupt_bio_byte error path
If no arguments were provided to the corrupt_bio_byte feature an error
should be returned immediately.
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Diffstat (limited to 'drivers/md/dm-flakey.c')
| -rw-r--r-- | drivers/md/dm-flakey.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c index 89f73ca..f84c080 100644 --- a/drivers/md/dm-flakey.c +++ b/drivers/md/dm-flakey.c @@ -81,8 +81,10 @@ static int parse_features(struct dm_arg_set *as, struct flakey_c *fc, * corrupt_bio_byte <Nth_byte> <direction> <value> <bio_flags> */ if (!strcasecmp(arg_name, "corrupt_bio_byte")) { - if (!argc) + if (!argc) { ti->error = "Feature corrupt_bio_byte requires parameters"; + return -EINVAL; + } r = dm_read_arg(_args + 1, as, &fc->corrupt_bio_byte, &ti->error); if (r) |
