diff options
| author | Dan Carpenter <error27@gmail.com> | 2009-07-19 14:46:09 +0300 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2009-07-30 16:03:43 +0930 |
| commit | f294526279cda8934b0313ebd02184a16ba888c9 (patch) | |
| tree | a89b108800b8f8cdcf6a6eae4f69bb10df3ac79c /drivers/lguest | |
| parent | 658874f05d040ca96eb5ba9b1c30ce0ff287d762 (diff) | |
| download | op-kernel-dev-f294526279cda8934b0313ebd02184a16ba888c9.zip op-kernel-dev-f294526279cda8934b0313ebd02184a16ba888c9.tar.gz | |
lguest: dereferencing freed mem in add_eventfd()
"new" was freed and then dereferenced. Also the return value wasn't being
used so I modified the caller as well.
Compile tested only. Found by smatch (http://repo.or.cz/w/smatch.git).
regards,
dan carpenter
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/lguest')
| -rw-r--r-- | drivers/lguest/lguest_user.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/lguest/lguest_user.c b/drivers/lguest/lguest_user.c index 9f9a295..407722a 100644 --- a/drivers/lguest/lguest_user.c +++ b/drivers/lguest/lguest_user.c @@ -52,8 +52,9 @@ static int add_eventfd(struct lguest *lg, unsigned long addr, int fd) new->map[new->num].addr = addr; new->map[new->num].event = eventfd_ctx_fdget(fd); if (IS_ERR(new->map[new->num].event)) { + int err = PTR_ERR(new->map[new->num].event); kfree(new); - return PTR_ERR(new->map[new->num].event); + return err; } new->num++; @@ -83,7 +84,7 @@ static int attach_eventfd(struct lguest *lg, const unsigned long __user *input) err = add_eventfd(lg, addr, fd); mutex_unlock(&lguest_lock); - return 0; + return err; } /*L:050 Sending an interrupt is done by writing LHREQ_IRQ and an interrupt |
