summaryrefslogtreecommitdiffstats
path: root/drivers/leds
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-10-24 16:42:29 +0200
committerJacek Anaszewski <j.anaszewski@samsung.com>2015-11-03 09:00:04 +0100
commit6cc7624415466022749a868c159ac68367bc9a0e (patch)
treec4aa632b6d6baf0e01abda91e08f65b6e10af276 /drivers/leds
parent4b6ba5e28b2903fa8b51c6d5fdafb2979fe6eeab (diff)
downloadop-kernel-dev-6cc7624415466022749a868c159ac68367bc9a0e.zip
op-kernel-dev-6cc7624415466022749a868c159ac68367bc9a0e.tar.gz
leds: bcm6328: add missing of_node_put
for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; @@ for_each_available_child_of_node(root, child) { ... when != of_node_put(child) when != e = child ( return child; | + of_node_put(child); ? return ...; ) ... } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Diffstat (limited to 'drivers/leds')
-rw-r--r--drivers/leds/leds-bcm6328.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c
index 18de094..c7ea5c6 100644
--- a/drivers/leds/leds-bcm6328.c
+++ b/drivers/leds/leds-bcm6328.c
@@ -403,8 +403,10 @@ static int bcm6328_leds_probe(struct platform_device *pdev)
rc = bcm6328_led(dev, child, reg, mem, lock,
blink_leds, blink_delay);
- if (rc < 0)
+ if (rc < 0) {
+ of_node_put(child);
return rc;
+ }
}
return 0;
OpenPOWER on IntegriCloud