summaryrefslogtreecommitdiffstats
path: root/drivers/leds
diff options
context:
space:
mode:
authorRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>2015-07-31 13:36:21 +0200
committerJacek Anaszewski <j.anaszewski@samsung.com>2015-08-28 14:06:19 +0200
commite5b5a61fcb3743f1dacf9e20d28f48423cecf0c1 (patch)
tree957d8c7ed82f3796d1307b3bb300ad1c2507800f /drivers/leds
parent4fc5af86837d983d7b1dd4edad245454e1874fa0 (diff)
downloadop-kernel-dev-e5b5a61fcb3743f1dacf9e20d28f48423cecf0c1.zip
op-kernel-dev-e5b5a61fcb3743f1dacf9e20d28f48423cecf0c1.tar.gz
leds/led-class: Add missing put_device()
Devices found by class_find_device must be freed with put_device(). Otherwise the reference count will not work properly. Fixes: a96aa64cb572 ("leds/led-class: Handle LEDs with the same name") Reported-by: Alan Tull <delicious.quinoa@gmail.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Diffstat (limited to 'drivers/leds')
-rw-r--r--drivers/leds/led-class.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index beabfbc..ca51d58 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -228,12 +228,15 @@ static int led_classdev_next_name(const char *init_name, char *name,
{
unsigned int i = 0;
int ret = 0;
+ struct device *dev;
strlcpy(name, init_name, len);
- while (class_find_device(leds_class, NULL, name, match_name) &&
- (ret < len))
+ while ((ret < len) &&
+ (dev = class_find_device(leds_class, NULL, name, match_name))) {
+ put_device(dev);
ret = snprintf(name, len, "%s_%u", init_name, ++i);
+ }
if (ret >= len)
return -ENOMEM;
OpenPOWER on IntegriCloud