diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-10-24 16:42:28 +0200 |
---|---|---|
committer | Jacek Anaszewski <j.anaszewski@samsung.com> | 2015-11-03 09:00:02 +0100 |
commit | 4b6ba5e28b2903fa8b51c6d5fdafb2979fe6eeab (patch) | |
tree | 1c643a5c11fe9b35cc74cc2c8bbf2f0e3dfc037d /drivers/leds/leds-bcm6358.c | |
parent | dde4afe7656084b7886f3b721530c32209842390 (diff) | |
download | op-kernel-dev-4b6ba5e28b2903fa8b51c6d5fdafb2979fe6eeab.zip op-kernel-dev-4b6ba5e28b2903fa8b51c6d5fdafb2979fe6eeab.tar.gz |
leds: bcm6358: add missing of_node_put
for_each_available_child_of_node performs an of_node_get on each
iteration, so a break out of the loop requires an of_node_put.
A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):
// <smpl>
@@
expression root,e;
local idexpression child;
@@
for_each_available_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
(
return child;
|
+ of_node_put(child);
? return ...;
)
...
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Diffstat (limited to 'drivers/leds/leds-bcm6358.c')
-rw-r--r-- | drivers/leds/leds-bcm6358.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/leds/leds-bcm6358.c b/drivers/leds/leds-bcm6358.c index 7ea3526..82b4ee1 100644 --- a/drivers/leds/leds-bcm6358.c +++ b/drivers/leds/leds-bcm6358.c @@ -215,8 +215,10 @@ static int bcm6358_leds_probe(struct platform_device *pdev) } rc = bcm6358_led(dev, child, reg, mem, lock); - if (rc < 0) + if (rc < 0) { + of_node_put(child); return rc; + } } return 0; |