diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2017-03-23 21:17:48 +0200 |
|---|---|---|
| committer | Jacek Anaszewski <jacek.anaszewski@gmail.com> | 2017-03-23 20:33:51 +0100 |
| commit | 96962178475ae8040f40dff3a44beb9f69181421 (patch) | |
| tree | 3629b3fece6df8d36a6aa7be8ba78075650b46c7 /drivers/leds/Kconfig | |
| parent | ac572452156963588b285049ba3895bef0f17642 (diff) | |
| download | op-kernel-dev-96962178475ae8040f40dff3a44beb9f69181421.zip op-kernel-dev-96962178475ae8040f40dff3a44beb9f69181421.tar.gz | |
leds: lp3952: Remove ACPI support for lp3952
In ACPI world any ID should be carefully chosen and registered
officially. The discussion [1] as I read it gets to wilful assignment
an ID for non-existing real DSDT example.
Rafael already told [2] how this device would be enumerated using
compatible string. To be more precise look at the possible DSDT excerpt
below:
Device (LDX0) {
Name (_HID, "PRP0001")
Name (_DDN, "TI LP3952 compatible led driver")
...
})
Name (_DSD, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package () {"compatible", "ti,lp3952"},
...
}
})
Based on above, remove non-official ACPI IDs and enumeration from the
driver.
Note: currently driver has no compatible strings at all, to make above
working one should add at least one.
[1] https://e2e.ti.com/support/power_management/led_driver/f/192/t/524926
[2] https://www.spinics.net/lists/linux-acpi/msg67125.html
Cc: Tony Makkiel <tony.makkiel@daqri.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Diffstat (limited to 'drivers/leds/Kconfig')
| -rw-r--r-- | drivers/leds/Kconfig | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index e9ba04d..8075d2e 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -249,7 +249,6 @@ config LEDS_LP3952 tristate "LED Support for TI LP3952 2 channel LED driver" depends on LEDS_CLASS depends on I2C - depends on ACPI depends on GPIOLIB select REGMAP_I2C help |
