diff options
author | David Brownell <david-b@pacbell.net> | 2007-07-31 00:39:45 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-31 15:39:44 -0700 |
commit | 082c8cb4e5e68c0fd29cc10c59db94d2284fd2b0 (patch) | |
tree | 5f4ec8042b29272f0fd0c28b2cc2c0bb63f38dc0 /drivers/isdn | |
parent | 2604288f45605d1b2844f001dc3141149667b3d1 (diff) | |
download | op-kernel-dev-082c8cb4e5e68c0fd29cc10c59db94d2284fd2b0.zip op-kernel-dev-082c8cb4e5e68c0fd29cc10c59db94d2284fd2b0.tar.gz |
spi device setup gets better error checking
This updates some error reporting paths in SPI device setup:
- Move validation logic for SPI chipselects to spi_new_device(),
which is where it should always have been.
- In spi_new_device(), emit error messages if the device can't
be created. This is LOTS better than a silent failure; though
eventually, the calling convention should probably change to
use the <linux/err.h> conventions.
- Includes one previously-missing check: SPI masters must always
have at least one chipselect, even for dedicated busses which
always keep it selected!
It also adds a FIXME (IDR for dynamic ID allocation) so the issue doesn't live
purely in my mailbox.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/isdn')
0 files changed, 0 insertions, 0 deletions