diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-09-03 15:31:00 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-09-03 15:37:29 -0400 |
| commit | 9fef76857feed8e94ca3a5ee37db644f04a9488b (patch) | |
| tree | 0b2e278ce7291cde1301fdb4d339ed0dc793f691 /drivers/isdn | |
| parent | b379135c40163ae79ba7a54e6928b53983e74ee8 (diff) | |
| download | op-kernel-dev-9fef76857feed8e94ca3a5ee37db644f04a9488b.zip op-kernel-dev-9fef76857feed8e94ca3a5ee37db644f04a9488b.tar.gz | |
mISDN: fix possible memory leak in hfcmulti_init()
hc has been allocated in this function and missing free it before
leaving from some error handling cases.
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
| -rw-r--r-- | drivers/isdn/hardware/mISDN/hfcmulti.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c index 5e402cf2..f027942 100644 --- a/drivers/isdn/hardware/mISDN/hfcmulti.c +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c @@ -5059,6 +5059,7 @@ hfcmulti_init(struct hm_map *m, struct pci_dev *pdev, printk(KERN_INFO "HFC-E1 #%d has overlapping B-channels on fragment #%d\n", E1_cnt + 1, pt); + kfree(hc); return -EINVAL; } maskcheck |= hc->bmask[pt]; @@ -5086,6 +5087,7 @@ hfcmulti_init(struct hm_map *m, struct pci_dev *pdev, if ((poll >> 1) > sizeof(hc->silence_data)) { printk(KERN_ERR "HFCMULTI error: silence_data too small, " "please fix\n"); + kfree(hc); return -EINVAL; } for (i = 0; i < (poll >> 1); i++) |
