diff options
author | Jan Kiszka <jan.kiszka@siemens.com> | 2017-04-24 12:30:15 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-18 16:43:55 +0200 |
commit | 2c0ac5b48a3586f612b85755b041ed7733dc8e6b (patch) | |
tree | 8c7214a39078df3767d874c16c5391a468658faa /drivers/isdn | |
parent | be40597a1bc173bf9dadccdf5388b956f620ae8f (diff) | |
download | op-kernel-dev-2c0ac5b48a3586f612b85755b041ed7733dc8e6b.zip op-kernel-dev-2c0ac5b48a3586f612b85755b041ed7733dc8e6b.tar.gz |
serial: exar: Fix stuck MSIs
After migrating 8250_exar to MSI in 172c33cb61da, we can get stuck
without further interrupts because of the special wake-up event these
chips send. They are only cleared by reading INT0. As we fail to do so
during startup and shutdown, we can leave the interrupt line asserted,
which is fatal with edge-triggered MSIs.
Add the required reading of INT0 to startup and shutdown. Also account
for the fact that a pending wake-up interrupt means we have to return 1
from exar_handle_irq. Drop the unneeded reading of INT1..3 along with
this - those never reset anything.
An alternative approach would have been disabling the wake-up interrupt.
Unfortunately, this feature (REGB[17] = 1) is not available on the
XR17D15X.
Fixes: 172c33cb61da ("serial: exar: Enable MSI support")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/isdn')
0 files changed, 0 insertions, 0 deletions