summaryrefslogtreecommitdiffstats
path: root/drivers/isdn/hisax/w6692.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2009-07-12 22:05:03 +0200
committerKarsten Keil <keil@b1-systems.de>2009-07-25 20:22:51 +0200
commit3cad3da3ed9ece03704f7d67e038b8ae710fa312 (patch)
treedc20a8b7272d027b889a8c3df6ca0963ded3d018 /drivers/isdn/hisax/w6692.c
parenta900845e56617edc005fd8f35bfd5a407aaf96c8 (diff)
downloadop-kernel-dev-3cad3da3ed9ece03704f7d67e038b8ae710fa312.zip
op-kernel-dev-3cad3da3ed9ece03704f7d67e038b8ae710fa312.tar.gz
drivers/isdn: Drop unnecessary NULL test
The result of container_of should not be NULL. In particular, in this case the argument to the enclosing function has passed though INIT_WORK, which dereferences it, implying that its container cannot be NULL. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ identifier fn,work,x,fld; type T; expression E1,E2; statement S; @@ static fn(struct work_struct *work) { ... when != work = E1 x = container_of(work,T,fld) ... when != x = E2 - if (x == NULL) S ... } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Karsten Keil <keil@b1-systems.de>
Diffstat (limited to 'drivers/isdn/hisax/w6692.c')
-rw-r--r--drivers/isdn/hisax/w6692.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/isdn/hisax/w6692.c b/drivers/isdn/hisax/w6692.c
index bb1c8dd..c4d862c 100644
--- a/drivers/isdn/hisax/w6692.c
+++ b/drivers/isdn/hisax/w6692.c
@@ -105,8 +105,6 @@ W6692_bh(struct work_struct *work)
container_of(work, struct IsdnCardState, tqueue);
struct PStack *stptr;
- if (!cs)
- return;
if (test_and_clear_bit(D_CLEARBUSY, &cs->event)) {
if (cs->debug)
debugl1(cs, "D-Channel Busy cleared");
OpenPOWER on IntegriCloud