summaryrefslogtreecommitdiffstats
path: root/drivers/isdn/hardware/mISDN/hfcsusb.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-03-26 21:20:48 +0000
committerDavid S. Miller <davem@davemloft.net>2012-03-27 22:42:32 -0400
commit819a100846295461bc0f1bfcb8e5ab11c1bc4cdb (patch)
tree60a01beefe73812d91e6459bcfa0cccd54ea2e59 /drivers/isdn/hardware/mISDN/hfcsusb.c
parentc54e9bd38a06babf94fd45e5f1df9a1109e12818 (diff)
downloadop-kernel-dev-819a100846295461bc0f1bfcb8e5ab11c1bc4cdb.zip
op-kernel-dev-819a100846295461bc0f1bfcb8e5ab11c1bc4cdb.tar.gz
mISDN: array underflow in open_bchannel()
There are two channels here. User space starts counting channels at one but in the kernel we start at zero. If the user passes in a zero channel that's invalid and could lead to memory corruption. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn/hardware/mISDN/hfcsusb.c')
-rw-r--r--drivers/isdn/hardware/mISDN/hfcsusb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
index 6023387..8cde2a0 100644
--- a/drivers/isdn/hardware/mISDN/hfcsusb.c
+++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
@@ -486,7 +486,7 @@ open_bchannel(struct hfcsusb *hw, struct channel_req *rq)
{
struct bchannel *bch;
- if (rq->adr.channel > 2)
+ if (rq->adr.channel == 0 || rq->adr.channel > 2)
return -EINVAL;
if (rq->protocol == ISDN_P_NONE)
return -EINVAL;
OpenPOWER on IntegriCloud