diff options
| author | Tilman Schmidt <tilman@imap.cc> | 2013-01-21 11:57:21 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-01-21 17:36:02 -0500 |
| commit | d721a1752ba544df8d7d36959038b26bc92bdf80 (patch) | |
| tree | d119c0f503bf75925ba005c94f286f6585dafaef /drivers/isdn/gigaset | |
| parent | 2f62d5aa2879dc380881b2c74d042051dbb60bc8 (diff) | |
| download | op-kernel-dev-d721a1752ba544df8d7d36959038b26bc92bdf80.zip op-kernel-dev-d721a1752ba544df8d7d36959038b26bc92bdf80.tar.gz | |
isdn/gigaset: fix zero size border case in debug dump
If subtracting 12 from l leaves zero we'd do a zero size allocation,
leading to an oops later when we try to set the NUL terminator.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn/gigaset')
| -rw-r--r-- | drivers/isdn/gigaset/capi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c index 68452b7..03a0a01 100644 --- a/drivers/isdn/gigaset/capi.c +++ b/drivers/isdn/gigaset/capi.c @@ -248,6 +248,8 @@ static inline void dump_rawmsg(enum debuglevel level, const char *tag, CAPIMSG_APPID(data), CAPIMSG_MSGID(data), l, CAPIMSG_CONTROL(data)); l -= 12; + if (l <= 0) + return; dbgline = kmalloc(3 * l, GFP_ATOMIC); if (!dbgline) return; |
