diff options
| author | Axel Lin <axel.lin@ingics.com> | 2013-05-06 17:03:32 +0800 |
|---|---|---|
| committer | Simon Horman <horms+renesas@verge.net.au> | 2013-06-06 10:23:58 +0900 |
| commit | dfaf820a13ec160f06556e08dab423818ba87f14 (patch) | |
| tree | 76988415570371b12820c682ccc1b8094e5b97c6 /drivers/irqchip | |
| parent | c7788792a5e7b0d5d7f96d0766b4cb6112d47d75 (diff) | |
| download | op-kernel-dev-dfaf820a13ec160f06556e08dab423818ba87f14.zip op-kernel-dev-dfaf820a13ec160f06556e08dab423818ba87f14.tar.gz | |
irqchip: renesas-irqc: Fix irqc_probe error handling
The code in goto err3 path is wrong because it will call fee_irq() with k == 0,
which means it does free_irq(p->irq[-1].requested_irq, &p->irq[-1]);
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Diffstat (limited to 'drivers/irqchip')
| -rw-r--r-- | drivers/irqchip/irq-renesas-irqc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c index 927bff3..2f404ba 100644 --- a/drivers/irqchip/irq-renesas-irqc.c +++ b/drivers/irqchip/irq-renesas-irqc.c @@ -248,8 +248,8 @@ static int irqc_probe(struct platform_device *pdev) return 0; err3: - for (; k >= 0; k--) - free_irq(p->irq[k - 1].requested_irq, &p->irq[k - 1]); + while (--k >= 0) + free_irq(p->irq[k].requested_irq, &p->irq[k]); irq_domain_remove(p->irq_domain); err2: |
