summaryrefslogtreecommitdiffstats
path: root/drivers/iommu/amd_iommu.c
diff options
context:
space:
mode:
authorSuravee Suthikulpanit <suravee.suthikulpanit@amd.com>2018-02-05 05:45:53 -0500
committerJoerg Roedel <jroedel@suse.de>2018-02-13 19:31:20 +0100
commitc5611a8751e67595e4e7d3feaff3c900b92094b9 (patch)
treeb833cce9dd9ad3501f7ba151aadf09faeaa2a6b9 /drivers/iommu/amd_iommu.c
parent7928b2cbe55b2a410a0f5c1f154610059c57b1b2 (diff)
downloadop-kernel-dev-c5611a8751e67595e4e7d3feaff3c900b92094b9.zip
op-kernel-dev-c5611a8751e67595e4e7d3feaff3c900b92094b9.tar.gz
iommu: Do not return error code for APIs with size_t return type
Currently, iommu_unmap, iommu_unmap_fast and iommu_map_sg return size_t. However, some of the return values are error codes (< 0), which can be misinterpreted as large size. Therefore, returning size 0 instead to signify failure to map/unmap. Cc: Joerg Roedel <joro@8bytes.org> Cc: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/amd_iommu.c')
-rw-r--r--drivers/iommu/amd_iommu.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 74788fd..ecdeb04 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3050,7 +3050,7 @@ static size_t amd_iommu_unmap(struct iommu_domain *dom, unsigned long iova,
size_t unmap_size;
if (domain->mode == PAGE_MODE_NONE)
- return -EINVAL;
+ return 0;
mutex_lock(&domain->api_lock);
unmap_size = iommu_unmap_page(domain, iova, page_size);
OpenPOWER on IntegriCloud