summaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2016-12-29 10:13:43 -0800
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2016-12-29 10:20:19 -0800
commit3a11c0e1f1394e9d871dd8e68f9ce01d7c96e28d (patch)
tree8e76ff4c041c1c8fdd33756166f8de2a3ea2fc5a /drivers/input
parent0c54fe74db73499637315d6b3d83a7adbc6f32aa (diff)
downloadop-kernel-dev-3a11c0e1f1394e9d871dd8e68f9ce01d7c96e28d.zip
op-kernel-dev-3a11c0e1f1394e9d871dd8e68f9ce01d7c96e28d.tar.gz
Input: synaptics-rmi4 - remove redundant null check on rmi_dev
rmi_dev is currently being dereferenced before it null checked, however, after deeper inspecting, rmi_dev can never be null, so just remove this redundant check. Fixes CoverityScan CID 1391218 ("Dereference before null check") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/rmi4/rmi_f03.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/input/rmi4/rmi_f03.c b/drivers/input/rmi4/rmi_f03.c
index 8a7ca3e..9a1b099 100644
--- a/drivers/input/rmi4/rmi_f03.c
+++ b/drivers/input/rmi4/rmi_f03.c
@@ -175,9 +175,6 @@ static int rmi_f03_attention(struct rmi_function *fn, unsigned long *irq_bits)
int i;
int error;
- if (!rmi_dev)
- return -ENODEV;
-
if (drvdata->attn_data.data) {
/* First grab the data passed by the transport device */
if (drvdata->attn_data.size < ob_len) {
OpenPOWER on IntegriCloud