summaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2016-12-20 13:23:30 -0800
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2016-12-29 10:10:52 -0800
commit0c54fe74db73499637315d6b3d83a7adbc6f32aa (patch)
tree9633963a54c626b3fea38c060f68369d752de753 /drivers/input
parentb29c139a15b627cd3db803332c89f0ea1b94fc7b (diff)
downloadop-kernel-dev-0c54fe74db73499637315d6b3d83a7adbc6f32aa.zip
op-kernel-dev-0c54fe74db73499637315d6b3d83a7adbc6f32aa.tar.gz
Input: synaptics-rmi4 - check for non zero version logically dead code
version is a u8, the check for version > 0 means that version can only be zero, so the subsequent check for version != 0 is never true and hence is redudant code and can be removed. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/rmi4/rmi_f34.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/input/rmi4/rmi_f34.c b/drivers/input/rmi4/rmi_f34.c
index 9774dfb..c3285ce 100644
--- a/drivers/input/rmi4/rmi_f34.c
+++ b/drivers/input/rmi4/rmi_f34.c
@@ -441,8 +441,6 @@ static int rmi_f34_probe(struct rmi_function *fn)
/* v5 code only supported version 0, try V7 probe */
if (version > 0)
return rmi_f34v7_probe(f34);
- else if (version != 0)
- return -ENODEV;
f34->bl_version = 5;
OpenPOWER on IntegriCloud