summaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorUwe Kleine-König <Uwe.Kleine-Koenig@digi.com>2008-07-30 10:33:43 -0400
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2008-07-30 10:40:35 -0400
commit74dd4393445ba37b79041d92de6ff7e7b68a4aec (patch)
treec223fdc1d9c5cd1d8217a782d0d0ed7dccf99832 /drivers/input
parent558a171d778293176bf70bc34e18a92faef5bfa1 (diff)
downloadop-kernel-dev-74dd4393445ba37b79041d92de6ff7e7b68a4aec.zip
op-kernel-dev-74dd4393445ba37b79041d92de6ff7e7b68a4aec.tar.gz
Input: gpio-keys - fix possible NULL pointer dereference
bdata->button is used in gpio_check_button but never initialized. Having a device with debounce_interval != 0 without this patch resulted on an oops on my machine. Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/keyboard/gpio_keys.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index be58730..1a92f4b 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -118,6 +118,7 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
unsigned int type = button->type ?: EV_KEY;
bdata->input = input;
+ bdata->button = button;
setup_timer(&bdata->timer,
gpio_check_button, (unsigned long)bdata);
OpenPOWER on IntegriCloud